Skip to content

Playbook Consolidation - Redeploy Certificates#6324

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mtnbikenc:consolidate-redeploy-certificates
Dec 4, 2017
Merged

Playbook Consolidation - Redeploy Certificates#6324
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mtnbikenc:consolidate-redeploy-certificates

Conversation

@mtnbikenc
Copy link
Member

@mtnbikenc mtnbikenc commented Dec 1, 2017

This PR moves the certificate redeploy playbooks out of {byo,common}/openshift-cluster and into their respective component areas.

  • playbooks/openshift-etcd (redeploy-certificates.yml, redeploy-ca.yml)
  • playbooks/openshift-master (redeploy-certificates.yml, redeploy-openshift-ca.yml)
  • playbooks/openshift-node (redeploy-certificates.yml)
  • playbooks/openshift-hosted (redeploy-registry-certificates.yml, redeploy-router-certificates.yml)

playbooks/byo/openshift-cluster/redeploy-certificates.yml was moved to
playbooks/redeploy-certificates.yml

Trello: https://trello.com/c/zCz6RIHM/578-2-playbook-consolidation-openshift-cluster-redeploy-certificates

@mtnbikenc mtnbikenc requested a review from abutcher December 1, 2017 14:58
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2017
@mtnbikenc
Copy link
Member Author

mtnbikenc commented Dec 1, 2017

Attempting to kick the bot.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2017
@mtnbikenc
Copy link
Member Author

mtnbikenc commented Dec 1, 2017

Bot kick successful.
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2017
michaelgugino
michaelgugino approved these changes Dec 4, 2017
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2017
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 4, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2017 •
edited
Loading

@mtnbikenc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/upgrade 0b80aca link /test upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 4, 2017

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 4112352 into openshift:master Dec 4, 2017
@mtnbikenc mtnbikenc deleted the consolidate-redeploy-certificates branch December 4, 2017 19:59
@mtnbikenc
Copy link
Member Author

mtnbikenc commented Dec 12, 2017

/cherrypick release-3.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 12, 2017
Closed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 12, 2017

@mtnbikenc: new pull request created: #6441

Details

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abutcher abutcher Awaiting requested review from abutcher

@kwoodson kwoodson Awaiting requested review from kwoodson

1 more reviewer

@michaelgugino michaelgugino michaelgugino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michaelgugino michaelgugino

Labels

lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mtnbikenc @openshift-merge-robot @openshift-ci-robot @openshift-cherrypick-robot @michaelgugino